On Wed, Aug 31, 2016 at 4:27 PM, Jacob Keller <jacob.e.keller@xxxxxxxxx> wrote:
> From: Jacob Keller <jacob.keller@xxxxxxxxx>
>
> Hopefully the final revision here. I've squashed in the memory leak fix
> suggested by Stefan, and the suggested changes from Junio, including his
> re-worded commit messages.
>
> interdiff between v11 and v12
> diff --git c/path.c w/path.c
> index 3dbc4478a4aa..ba60c9849ef7 100644
> --- c/path.c
> +++ w/path.c
> @@ -467,7 +467,7 @@ const char *worktree_git_path(const struct worktree *wt, const char *fmt, ...)
> return pathname->buf;
> }
>
> -/* Returns 0 on success, non-zero on failure. */
> +/* Returns 0 on success, negative on failure. */
> #define SUBMODULE_PATH_ERR_NOT_CONFIGURED -1
> static int do_submodule_path(struct strbuf *buf, const char *path,
> const char *fmt, va_list args)
> @@ -523,8 +523,10 @@ char *git_pathdup_submodule(const char *path, const char *fmt, ...)
> va_start(args, fmt);
> err = do_submodule_path(&buf, path, fmt, args);
> va_end(args);
> - if (err)
> + if (err) {
> + strbuf_release(&buf);
> return NULL;
> + }
> return strbuf_detach(&buf, NULL);
> }
>
Skimmed all patches very quickly and they look good to me.
Thanks,
Stefan