Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Tue, 30 Aug 2016 10:21:45 -0700
Cc: git@xxxxxxxxxxxxxxx, Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
In-reply-to: <alpine.DEB.2.20.1608301116450.129229@virtualbox> (Johannes Schindelin's message of "Tue, 30 Aug 2016 11:17:38 +0200 (CEST)")
References: <cover.1471968378.git.johannes.schindelin@gmx.de> <cover.1472219214.git.johannes.schindelin@gmx.de> <0fde7522953f71bd07e6aa7a15081dbf069aa6b6.1472219214.git.johannes.schindelin@gmx.de> <xmqq37ln9ubo.fsf@gitster.mtv.corp.google.com> <alpine.DEB.2.20.1608301116450.129229@virtualbox>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> I still think that it is a serious mistake for library functions to die().
> But I have no time to take care of git_parse_source() right now.

I think we already agreed on both points during the previous round
of review ;-)

References:
- [PATCH 00/15] Lib'ify quite a few functions in sequencer.c
  - From: Johannes Schindelin
- [PATCH v2 00/14] Lib'ify quite a few functions in sequencer.c
  - From: Johannes Schindelin
- [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()
  - From: Johannes Schindelin
- Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()
  - From: Junio C Hamano
- Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()
  - From: Johannes Schindelin

Prev by Date: Re: [PATCH v2 08/14] sequencer: lib'ify read_and_refresh_cache()
Next by Date: Re: git am and duplicate signatures
Previous by thread: Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()
Next by thread: [PATCH v2 12/14] sequencer: lib'ify save_head()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]