Hi Junio, On Tue, 30 Aug 2016, Johannes Schindelin wrote: > On Mon, 29 Aug 2016, Junio C Hamano wrote: > > > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > > > I am not sure if it should be left as the responsibility of the > > > caller (i.e. check the_index.initialized to bark at a caller that > > > forgets to read from an index) ... > > > > Scatch that. That would not work in a freshly created repository > > before doing any "git add". An empty index is a normal state, so it > > would not just be annoying to warn "You called me without reading > > the index" but is simply wrong. > > Fine. I changed it to assert that the_index.initialized was set. Alas, that does not work, either. If no .git/index exists, read_index() will not set the "initialized" flag. So it turns out that I can either get distracted in a major way, or drop the patch. I opt for the latter. Ciao, Dscho