Junio C Hamano <gitster@xxxxxxxxx> writes: >> + if (git_config_from_file(populate_opts_cb, git_path_opts_file(), *opts) < 0) >> + return error(_("Malformed options sheet: %s"), >> + git_path_opts_file()); >> + return 0; > > As discussed, perhaps have a comment immediately before calling > config-from-file that says that the call could die when it is fed a > syntactically broken file, but we ignore it for now because we will > be writing the file we have written, or something? Obviously we will be _READING_ here ;-)