Hey Junio,
On Sat, Aug 27, 2016 at 4:37 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Pranit Bauva <pranit.bauva@xxxxxxxxx> writes:
>
>> +static int bisect_log(void)
>> +{
>> + struct strbuf buf = STRBUF_INIT;
>> +
>> + if (strbuf_read_file(&buf, git_path_bisect_log(), 256) < 0) {
>> + strbuf_release(&buf);
>> + return error(_("We are not bisecting.\n"));
>> + }
>> +
>> + printf("%s", buf.buf);
>> + strbuf_release(&buf);
>> +
>> + return 0;
>> +}
>
> Hmph, is it really necessary to slurp everything in a strbuf before
> sending it out to the standard output? Wouldn't it be sufficient to
> open a file descriptor for reading on the log file and then hand it
> over to copy.c::copy_fd()?
That is actually much better. Thanks!
Regards,
Pranit Bauva
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html