On Thu, Aug 25, 2016 at 1:39 PM, Jacob Keller <jacob.keller@xxxxxxxxx> wrote: > On Tue, Aug 23, 2016 at 10:47 AM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: >> On Tue, Aug 23, 2016 at 10:25 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >>> I am not so sure about that. If there is an existing place that is >>> buggy, shouldn't we fix that, instead of spreading the same bug >>> (assuming that it is a bug in the first place, which I do not have a >>> strong opinion on, at least not yet)? >>> >>> Can there be .git/modules/<foo>/ repository that is pointed at an >>> in-tree .git file when there is no "name" defined? >> >> If you're holding it wrong we can come into that state. >> * Checkout the submodule, >> * then remove .gitmodules as well as relevant config in .git/config. >> Result: Then we have a only a gitlink recorded as well as connected >> working tree to a gitdir inside a superprojects .git/modules/. >> > > Yea, but I think you're right that we shouldn't support that state. > What I'm worried about is the case where we can get this state doing > something sane/acceptable but I don't think we can. > > So we should support the gitlink to a repository stored at <path> > without stuff inside the .git/modules, and we should support submodule > gitlinks with a proper .gitmodules setup. I don't think we should > die() but we should error properly so I will introduce a _gently() > variant of these functions, and die properly in the regular flow. ok, thanks! >> Stepping back a bit, I think we'd want to document this expectation more >> in the man pages >> The name unlike the path of a submodule must not be changed (as the >> name is used internally to point at the submodules git dir) > > Agreed, this should be documented. Do you mind doing the documentation > patch for this? Well that documentation is sort of unrelated to this series, so no pressure. I have a revamp of the whole submodule documentation on my wish/TODO list, including this. Thanks, Stefan > > Thanks, > Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html