Jeff King <peff@xxxxxxxx> writes: > That is not too bad, I guess. I can switch it if you prefer that way. > Since there are only these two callers with two different sets of needs > (and the function is static), I just let them continue inspecting the > elements directly. I do not think it is too hard to refactor later when need arises; it is not like we have too many callers and this is a file-scope static helper to begin with. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html