Hi, On Fri, 19 Aug 2016, Junio C Hamano wrote: > Eric Wong <e@xxxxxxxxx> writes: > > > I'd be more comfortable keeping the EINVAL check that got > > snipped in your reply. O_CLOEXEC can be defined to non-zero in > > new userspace headers, but an older kernel chokes on it with > > EINVAL. > > Good point. Thanks. I tried to accomodate both of your suggestions by defining O_CLOEXEC in git-compat-util.h unless defined earlier, and by handling EINVAL via dropping O_CLOEXEC in a second call to open(). Please inspect the interdiff of the upcoming iteration. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html