On Sat, Aug 13, 2016 at 03:40:59PM +0700, Duy Nguyen wrote: > Ping.. There was some discussion after v4. I think the open issues are: - the commit message is rather terse (it should describe motivation, and can refer to the docs for the "how") - the syntax might be more clear as: [include-if "gitdir:..."] or [include "gitdir-is:..."] - there is an open question of whether we would like to go this route, maintaining backwards compatibility syntactically (and thus having these includes quietly skipped in older versions), or introduce a breaking syntax that could be more convenient, like: [if-gitdir(...):section] conditional-but-no-include-necessary = true I do not have a strong opinion myself, though I had written the original [include] assuming syntactic compatibility, and I think it has worked out (e.g., you can manipulate include.path via "git config" just as you would any other key). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html