On Wed, Aug 17, 2016 at 5:51 PM, Jacob Keller <jacob.e.keller@xxxxxxxxx> wrote: > From: Jacob Keller <jacob.keller@xxxxxxxxx> > > Currently, do_submodule_path relies on read_gitfile, which will die() if > it can't read from the specified gitfile. Unfortunately, this means that > do_submodule_path will not work when given the path to a submodule which > is checked out directly, such as a newly added submodule which you > cloned and then "git submodule add". Instead, replace the call with > resolve_gitdir. This first checks to see if we've been given a gitdir > already. > > Because resolve_gitdir may return the same buffer it was passed, we have > to check for this case as well, since strbuf_reset() will not work as > expected here, and indeed is not necessary. > > Signed-off-by: Jacob Keller <jacob.keller@xxxxxxxxx> > --- > path.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good, Thanks, Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html