On Tue, Aug 16, 2016 at 10:16:58AM +0200, Christian Couder wrote: > Changes from previous RFC version > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > - added documentation to all the 3 patches, Good idea. > - changed strtoul() to strtoumax() in the first 2 patches, as > suggested by Peff, > > - changed git_config_ulong() to git_config_int64() and used PRIuMAX > and uintmax_t in the last patch, as suggested by Peff, Thinking a bit, off_t is actually signed. So maybe PRIdMAX (which we don't seem to have compat macros for) would make more sense. I dunno if anybody actually cares. This value shouldn't be signed anyway, and nobody should be approaching the limits of a 64-bit number anyway (there is no point in limiting the incoming pack to the exabyte range). So I'm inclined not to worry about it. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html