On Mon, Aug 15, 2016 at 01:21:22PM -0700, Junio C Hamano wrote: > "Tom Tanner (BLOOMBERG/ LONDON)" <ttanner2@xxxxxxxxxxxxx> writes: > > > From: gitster@xxxxxxxxx > > To: john@xxxxxxxxxxxxx > > Cc: Tom Tanner (BLOOMBERG/ LONDON), davvid@xxxxxxxxx, git@xxxxxxxxxxxxxxx > > At: 08/14/16 04:21:18 > > > > John Keeping <john@xxxxxxxxxxxxx> writes: > > ... > >> POSIX specifies 127 as the exit status for "command not found" and 126 > >> for "command found but is not executable" [1] and at least bash and dash > >> follow this specification, while diff utilities generally use "1" for > >> the exit status we want to ignore. > >> > >> Handle 126 and 127 as special values, assuming that they always mean > >> that the command could not be executed. > > > > Sounds like a reasonable thing to do. Will queue; thanks. > > > Would it be possible to also treat signals (128 and above) as > > 'special' values as well (as I've seen some merge tools self > > destruct like that from time to time) > > Certainly, it feels safer to notice an unusual exit status code and > error out to force the user to take notice, but that reasoning > assumes that "128 and above" are noteworthy exceptions. Reading further in POSIX: The exit status of a command that terminated because it received a signal shall be reported as greater than 128. I think if we accept the argument above about diff utilities generally using low numbers for the status values we're ignoring intentionally, then we can just treat any value above 125 as a fatal error. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html