On 08/04/2016 08:43 PM, Junio C Hamano wrote: > Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: > >> The code branch used for the compaction heuristic incorrectly forgot to >> keep io in sync while the group was shifted. I think that could have >> led to reading past the end of the rchgo array. > > I had to read the first sentence three times as "incorrectly forgot" > was a bit strange thing to say (as if there is a situation where > 'forgetting to do' is the correct thing to do, but in that case we > would phrase it to stress that not doing is a deliberate choice, > e.g. 'refraining from doing'). Perhaps s/incorrectly // is the > simplest readability improvement? Yes, that makes it clearer. Will change. Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html