Re: [PATCH v9 39/41] apply: change error_routine when silent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 1, 2016 at 6:58 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote:
> On Sat, Jul 30, 2016 at 10:25 AM, Christian Couder
> <christian.couder@xxxxxxxxx> wrote:
>> +       /* This is to save some reporting routines */
>
> some?
>
> In case of a reroll could you be more specific?
> Specifically mention that we use these for the
> muting/when silence is requested.
> e.g.
> /* These control reporting routines, and are used e.g. for muting output */
>
>> +       void (*saved_error_routine)(const char *err, va_list params);
>> +       void (*saved_warn_routine)(const char *warn, va_list params);

I used the following instead of your suggestion:

    /*
     * This is to save reporting routines before using
     * set_error_routine() or set_warn_routine() to install muting
     * routines when in verbosity_silent mode.
     */

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]