Pranit Bauva <pranit.bauva@xxxxxxxxx> writes: > Reimplement the `check_and_set_terms` shell function in C and add > `check-and-set-terms` subcommand to `git bisect--helper` to call it from > git-bisect.sh > > Using `--check-and-set-terms` subcommand is a temporary measure to port > shell function in C so as to use the existing test suite. As more > functions are ported, this subcommand will be retired and will be called > by some other methods. I think "this subcommand will be retired but its implementation will be called by ..." would clarify the direction. > + if (!no_term_file && > + strcmp(cmd, terms->term_bad.buf) && > + strcmp(cmd, terms->term_good.buf)) > + return error(_("Invalid command: you're currently in a " > + "'%s' '%s' bisect"), terms->term_bad.buf, This changes a message text, switching from "... good/bad bisect." to "... 'good' 'bad' bisect". Intended? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html