Josh Triplett <josh@xxxxxxxxxxxxxxxx> writes: > Subject: Re: [PATCH v2 1/2] format-patch: Add a config option format.from ... At least s/Add/add/; but I would prefer an even shorter format-patch: format.from gives the default for --from > +static char *from; The same "this does not quite help the transition" comment applies to this one. > +enum from { > + FROM_AUTHOR, > + FROM_USER, > + FROM_VALUE, Drop trailing comma after the last enum definition (trailing comma after the last element in an array is OK, though). > +static void set_from(enum from type, const char *value) > +{ > + free(from); > + switch (type) { > + case FROM_AUTHOR: > + from = NULL; > + break; > + case FROM_USER: > + from = xstrdup(git_committer_info(IDENT_NO_DATE)); > + break; > + case FROM_VALUE: > + from = xstrdup(value); > + break; > + } > +} I tend to agree with what Jeff said; I'd queue 1/2 from the original round for now. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html