> On 30 Jul 2016, at 14:04, Jakub Narębski <jnareb@xxxxxxxxx> wrote: > > W dniu 30.07.2016 o 01:37, larsxschneider@xxxxxxxxx pisze: >> From: Lars Schneider <larsxschneider@xxxxxxxxx> >> >> packet_flush() would die in case of a write error even though for some callers >> an error would be acceptable. Add packet_flush_gentle() which writes a pkt-line >> flush packet and returns `0` for success and `1` for failure. > > I think it should be packet_flush_gently(), as in "to flush gently", > but this is only my opinion; I have not checked the naming rules and > practices for the rest of Git codebase. Agreed. This would match: object.c:int type_from_string_gently(const char *str, ssize_t len, int gentle) Thanks, Lars > >> >> Signed-off-by: Lars Schneider <larsxschneider@xxxxxxxxx> >> --- > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html