Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Wong <e@xxxxxxxxx> writes: > > >> Also, doesn't it break "git rebase" (non-interactive), or anything > >> that internally runs format-patch to individual files and then runs > >> am on each of them, anything that knows that each output file from > >> format-patch corresponds to a single change and there is no need to > >> split, badly if we do this unconditionally? > > > > Yes, rebase should probably unescape is_from_line matches. > > This shouldn't matter for "git rebase", as it only reads from the > mbox "From <commit object name> <datestamp>" line to learn the > original commit and extract the log message directly from there. OK. > But a third-party script that wants to read format-patch output > would be forced to upgrade, which is a pain if we make this change > unconditionally. I suppose unconditionally having mailsplit unescape ">From ... $DATE" lines might be acceptable? It'll still propagate these mistakes to older versions of git, but those installations will eventually become fewer. > >> IOW, shouldn't this be an optional feature to format-patch that > >> is triggered by passing a new command line option that currently > >> nobody is passing? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html