Hi Junio, You wrote: [...] > -test_expect_success 'bisect does not start with only one bad' ' > +test_expect_success 'bisect starts with only one bad' ' > git bisect reset && > git bisect start && > - git bisect bad $HASH4 || return 1 > - > - if git bisect next > - then > - echo Oops, should have failed. > - false > - else > - : > - fi > + git bisect bad $HASH4 && > + git bisect next > ' Ok, this is the purpose of your patch to make the above work. > -test_expect_success 'bisect does not start with only one good' ' > +test_expect_success 'bisect starts with only one good' ' > git bisect reset && > git bisect start && > git bisect good $HASH1 || return 1 But I don't understand the need to change the above comment when the test code for starting with one good commit is not changed. Thanks, Christian. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html