On Fri, Jul 22, 2016 at 12:52 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >> The approach to tests is different though. I like yours better than mine, >> as it doesn't add more tests, but strengthens existing tests. > > So... are you retracting > http://thread.gmane.org/gmane.comp.version-control.git/299995 and > instead giving an Ack to these two? > I like this series better * for the approach * for the tests * for the commit message So I do think this should be applied instead of what I sent. I am tempted to send a squash proposal like: (broken whitespaces) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 6f6d67a..77be97e 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -796,6 +796,8 @@ static int update_clone_task_finished(int result, return 0; } else { idx -= suc->list.nr; + if (idx >= suc->failed_clones_nr) + die("BUG: idx too large???"); ce = suc->failed_clones[idx]; strbuf_addf(err, _("Failed to clone '%s' a second time, aborting"), ce->name); -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html