On Thu, Jul 21, 2016 at 1:22 AM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > On Wed, Jul 20, 2016 at 10:24 AM, Nguyễn Thái Ngọc Duy > <pclouds@xxxxxxxxx> wrote: >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> >> --- >> Documentation/git-worktree.txt | 8 ++++++++ >> git-submodule.sh | 8 ++++---- >> 2 files changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt >> index 41350db..2a5661d 100644 >> --- a/Documentation/git-worktree.txt >> +++ b/Documentation/git-worktree.txt >> @@ -142,6 +142,14 @@ to share to all working directories: >> you are sure you always use sparse checkout for all working >> directories. >> >> + - `submodule.*` in current state should not be shared because the >> + information is tied to a particular version of .gitmodules in a >> + working directory. > > While the submodule.* settings are copied from the .gitmodules file initially, > they can be changed in the config later. (That was actually the whole > point of it, > so you can change the submodule remotes URL without having to change history.) > > And I would think that most submodule related settings (such as remote URL, > name, path, even depth recommendation) should be the same for all worktrees, > and a different value for one worktree is a carefully crafted > exception by the user. > > So while the .gitmodules file can diverge in the work trees I do not > think that the > actual remotes for the submodules in the different worktrees differ > though. The change > of the .gitmodule files may be because you checked out an old commit, that > has outdated information on where to get the submodule from. I just quickly glanced through the rest of this mail because, as a submodule ignorant, it's just mumbo jumbo to me. But what I see here is, there may be problems if we choose to share some submodule info, but I haven't seen any good thing from sharing any submodule info at all. I can imagine long term you may want to just clone a submodule repo once and share it across worktrees that use it, so maybe it's just me not seeing things and this may be a step towards that. Anyway, I assume some people will be working on the submodule side. And because I have not heard any bad thing about the new config design, I'm going to drop submodule patches from this series and focus on polishing config stuff. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html