On Thu, Jul 21, 2016 at 05:37:40PM -0400, Jeff King wrote: > The next three are to show the final diffstat after the commit > completes. It looks like the "should we reuse the worktree file?" > optimization in diff_populate_filespec() does not take into account > whether we will have to convert the contents, and it probably should. > The point is that sometimes mmap-ing the file contents is more efficient > than zlib inflating the object from disk. But if we have to exec an > extra process and read the whole object contents into a strbuf, that is > probably not a win. > > Adding a "return 0" at the top of reuse_worktree_file() drops our 6 to > 3 (but obviously it should actually check the attributes). Here's a patch for that. I put it in t0021, as well, since I couldn't find a more appropriate place. This means it conflicts with your earlier patch, but I think it does a better job of addressing the specific area it fixes. We may want further tests on top as we fix more areas (though as I said earlier, I think by avoiding the racy timestamps, your "commit" call drops to just a single invocation per file. That still seems like one more than we should need, but it at least matches your original expectation :) ). -- >8 -- Subject: diff: do not reuse worktree files that need "clean" conversion When accessing a blob for a diff, we may try to reuse file contents in the working tree, under the theory that it is faster to mmap those file contents than it would be to extract the content from the object database. When we have to filter those contents, though, that assumption does not hold. Even for our internal conversions like CRLF, we have to allocate and fill a new buffer anyway. But much worse, for external clean filters we have to exec an arbitrary script, and we have no idea how expensive it may be to run. So let's skip this optimization when conversion into git's "clean" form is required. This applies whenever the "want_file" flag is false. When it's true, the caller actually wants the smudged worktree contents, which the reused file by definition already has (in fact, this is a key optimization going the other direction, since reusing the worktree file there lets us skip smudge filters). Signed-off-by: Jeff King <peff@xxxxxxxx> --- diff.c | 7 +++++++ t/t0021-conversion.sh | 11 +++++++++++ 2 files changed, 18 insertions(+) diff --git a/diff.c b/diff.c index 7d03419..b43d3dd 100644 --- a/diff.c +++ b/diff.c @@ -2683,6 +2683,13 @@ static int reuse_worktree_file(const char *name, const unsigned char *sha1, int if (!FAST_WORKING_DIRECTORY && !want_file && has_sha1_pack(sha1)) return 0; + /* + * Similarly, if we'd have to convert the file contents anyway, that + * makes the optimization not worthwhile. + */ + if (!want_file && would_convert_to_git(name)) + return 0; + len = strlen(name); pos = cache_name_pos(name, len); if (pos < 0) diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh index 7bac2bc..e799e59 100755 --- a/t/t0021-conversion.sh +++ b/t/t0021-conversion.sh @@ -268,4 +268,15 @@ test_expect_success 'disable filter with empty override' ' test_must_be_empty err ' +test_expect_success 'diff does not reuse worktree files that need cleaning' ' + test_config filter.counter.clean "echo . >>count; sed s/^/clean:/" && + echo "file filter=counter" >.gitattributes && + test_commit one file && + test_commit two file && + + >count && + git diff-tree -p HEAD && + test_line_count = 0 count +' + test_done -- 2.9.2.506.g8452fe7 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html