Jeff King <peff@xxxxxxxx> writes: > On Sun, Jul 17, 2016 at 10:15:55AM +0200, Johannes Schindelin wrote: > >> FWIW I am slightly less worried about the conditional includes (it is >> already a horrible mess to figure out too-long include chains now, before >> having conditional includes, for example). I am slightly more worried >> about eventually needing to introduce support for something like >> >> [if-gitdir(...):section] >> thisSettingIsConditional = ... >> >> or even >> >> [if (worktree==...):section] >> anotherConditional = ... >> >> and then having two incompatible conditional constructs, one generic, the >> other one specific to [include]. >> >> In other words, if we already introduce a conditional construct, I'd >> rather have one that could easily be used for other conditions/sections >> when (and if) needed. > > I had assumed we would resist introducing anything like that, simply > because of backwards compatibility issues with the syntax. But I admit > that was just an assumption in my head; future compatibility with > reality is not guaranteed. :) I actually read that assumption between lines and almost wrote the same response that begins with "I think the untold assumption ever since the inclusion mechanism was introduced is..." ;-) A config file with "[include] path=..." in it would not include from the named path by ancient verison of Git, but at least it won't cause its parser to barf, and the assumption has been that it is a good property to keep when we introduce new and incompatible features. I can however understand it if somebody thinks it actually is better to actively break older Git implementations by forcing them to stop parsing when we introduce constructs that will lead them to do wrong things (e.g. missing some configuration defintions by not reading from the file that the user wanted to be read from), rather than making them silently ignore. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html