Re: Looking for help to understand external filter driver code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 07/20/2016 12:01 AM, Lars Schneider wrote:

On 19 Jul 2016, at 23:33, Junio C Hamano <gitster@xxxxxxxxx> wrote:

Lars Schneider <larsxschneider@xxxxxxxxx> writes:

Git writes --> 4 byte filename length
Git writes --> filename string

Why limit to 32GB?  Perhaps NUL termination is more appropriate
here?
OK, I will use NUL termination for the filename.
You're also right about the limit - I will use 8 byte to encode the
content length.
Is there any reason to encode the file length in binary format?
With all the discussions about big endianess, little endianess, 4GiB or 32 GiB.
How about simply writing the length as ASCII ?

Unless we don't want to have a "spare" field for future extensions,
it could be good to add an option field, which may be empty.
On top of that, do we want a field separator different from the line
separator ?

How about this:
<options><TAB><length><TAB><filename><NUL>

<options> may be "var=value;var2=value2" or simply ""
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]