Hi Junio, On Fri, 15 Jul 2016, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > The entire point of the previous patch was to make sure that we look at > > abbreviated patch IDs (using the diff *headers* only, but avoiding > > to load the blobs into memory and diff them) first, and only look at > > full patch IDs when the abbreviated patch IDs were not for the > > --cherry-pick test. > > > > Let's make sure that we actually avoid looking at the full patch ID, > > simply by corrupting an object that is needed for the full patch ID, and > > then seeing that --cherry-pick still works. > > I think "Avoid looking at" merely is the means to an end, and not > the goal by itself. By not looking at them, you hopefully run > faster. > > So I'd think a more useful addition under t/ would be to t/perf > somewhere, not "now you can rev-list --cherry-pick even inside a > corrupt repository, as long as corruption happens to be with blobs > and not the containing trees". I agree that we need a perf test. But we *also* need this test that ensures that we avoid loading blobs into memory, because that is the solution we do not want to see regress in the future. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html