On Fri, Jul 15, 2016 at 11:00:52AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > diff --git a/builtin/rev-list.c b/builtin/rev-list.c > > index b82bcc3..88d95a7 100644 > > --- a/builtin/rev-list.c > > +++ b/builtin/rev-list.c > > @@ -9,6 +9,7 @@ > > #include "log-tree.h" > > #include "graph.h" > > #include "bisect.h" > > +#include "progress.h" > > > > static const char rev_list_usage[] = > > "git rev-list [OPTION] <commit-id>... [ -- paths... ]\n" > > @@ -49,12 +50,17 @@ static const char rev_list_usage[] = > > " --bisect-all" > > ; > > > > +struct progress *progress; > > +unsigned progress_counter; > > Are these supposed to be file-scope static? Yep, they should be (I had originally made them part of the rev_info, but then forgot to give them "static" when I pulled them out). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html