Andrew Keller <andrew@xxxxxxxxxxxxxx> writes: > On 15.07.2016, at 1:02 nachm., Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> Expected outcome is an error saying "do not modify the index inside >> pre-commit hook", and a rejection. It was meant as a verification >> mechansim (hence it can be bypassed with --no-verify), not as a way >> to make changes that the user didn't tell "git commit" to make. > > Ah! Good to know, then. I’ll rewrite my hook to behave more correctly. No problem. >> It is just the implementation that dates back to the old days were >> too trusting that all users would behave (with its own definition of >> "behaving well", which may or may not match your expectation), did >> not anticipate that people would try to muck with the contents being >> commited in the hook, and did not implement such verification. Earlier you said you are working on a patch series. Since you have already looked at the codepath already, perhaps you may want to try a patch series to add the missing error-return instead, if you are interested? Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html