On Tue, Jul 12, 2016 at 10:40 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> This is a special SHA1. Let's keep it at one place, easier to replace >> later when the hash change comes, easier to recognize. Start with an >> underscore to reduce the chances somebody may override it without >> realizing it's predefined. >> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> >> --- >> t/t0000-basic.sh | 2 +- >> t/t1100-commit-tree-options.sh | 2 +- >> t/t4010-diff-pathspec.sh | 6 ++---- >> t/t4054-diff-bogus-tree.sh | 10 ++++------ >> t/t5504-fetch-receive-strict.sh | 4 ++-- >> t/test-lib.sh | 4 +++- >> 6 files changed, 13 insertions(+), 15 deletions(-) >> >> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh >> index 60811a3..48214e9 100755 >> --- a/t/t0000-basic.sh >> +++ b/t/t0000-basic.sh >> @@ -834,7 +834,7 @@ test_expect_success 'git write-tree should be able to write an empty tree' ' >> ' >> >> test_expect_success 'validate object ID of a known tree' ' >> - test "$tree" = 4b825dc642cb6eb9a060e54bf8d69288fbee4904 >> + test "$tree" = $_EMPTY_TREE >> ' > > I doubt the point of, and I'd rather not to see, the leading > underscore. Are there existing uses of the name that want it to > mean something different? No. There is EMPTY_TREE in use, but it's exactly what we expect. It's probably still a good idea to separate "global" variables from per-file ones. But I don't feel strongly about this, so if a re-roll is required (or somebody votes for underscore removal, including you), I'll remove the underscore. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html