On Tue, Jul 12, 2016 at 11:12:25AM -0700, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > >> Cool! Thanks for working on this. > > > > Well, I had to. Git for Windows v2.9.1 needs to get released, and I won't > > do that with a failing test suite. > > Let's do 2.9.2 together, as this is not limited to GfW. > > Taking Peff's suggestions into account, perhaps like the attached? It looks good to me. > It wasn't readily apparent to me why 2038 check worked, so I added a > short paragraph at the end, but those who know the test helper well > enough may find it redundant, in which case I am fine with removing > it. Definitely keep that paragraph. I am quite familiar with the test helper and it was not the outcome I initially expected. > +test_lazy_prereq 64BIT_TIME ' > + case "$(test-date show:iso 9999999999)" in > + *" -> 2038-"*) > + # on this platform, unsigned long is 32-bit, i.e. not large enough > + false I see you tightened up the match a little. TBH, I think we could probably just match the whole output string, but I doubt there's much chance of a false positive either way. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html