Junio C Hamano <gitster@xxxxxxxxx> writes: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> Since I now could reproduce the problem that Christoph showed, I >> decided to send the good patches out. To sum up, we use "unsigned >> long" in some places related to file size. On 32-bit systems, it's >> limited to 32 bits even though the system can handle files larger than >> that (off_t is 64-bit). This fixes it. >> >> clang -Wshorten-64-to-32 is very helpful to spot these problems. I >> have a couple more patches to clean all these warnings, but some need >> more code study to see what is the right way to do. >> >> Most of the rest seems harmless, except for the local variable "size" >> in builtin/pack-objects.c:write_one(). I might send 6/5 for that one. > > > Thanks. All looked nicely done. I'll queue with a few SQUASH??? (please ack or reject them) in between on 'pu' and push the result out later today. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html