Christopher Layne <clayne@xxxxxxxxxxxx> wrote:
> * cmd_clone should detect a missing $url arg before using it otherwise
> an uninitialized value error is emitted in even the simplest case of
> 'git svn clone' without arguments.
Thanks, this patch looks obviously correct.
I've eliminated the '* ' and space prefix from the version I've
applied since it's not the convention around here.
> Signed-off-by: Christopher Layne <clayne@xxxxxxxxxxxx>
Signed-off-by: Eric Wong <e@xxxxxxxxx>
And pushed to "master" of git://bogomips.org/git-svn
(I'll request for Junio to pull within a few days while
other changes pile up).
> sub cmd_clone {
> my ($url, $path) = @_;
> - if (!defined $path &&
> + if (!$url) {
> + die "SVN repository location required ",
> + "as a command-line argument\n";
"as a command-line argument" seems like an unnecessary phrase,
but I see we use it elsewhere; so it's fine here.
I might be tempted to queue up a separate patch
to eliminate this extra statement from the rest of git-svn,
though. Not sure if others feel the same way.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html