Re: [PATCH 0/5] consistent setup code for external commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 01, 2016 at 03:19:37PM -0700, Junio C Hamano wrote:

> > Here they are:
> >
> >   [1/5]: add an extra level of indirection to main()
> >   [2/5]: common-main: call git_extract_argv0_path()
> >   [3/5]: common-main: call sanitize_stdfds()
> >   [4/5]: common-main: call restore_sigpipe_to_default()
> >   [5/5]: common-main: call git_setup_gettext()
> 
> As this is also a fix to maint-2.8 track, I tweaked them to ensure
> that they apply there, and queued the result as jk/common-main.  I
> double checked the result by comparing the result of applying these
> five patches directly on top of master, and the result of merging
> that jk/common-main (based on maint-2.8) into master, and they seem
> to match.

Thanks, this obviously is a regression in v2.8, but I didn't even think
about that and just built it on top of master.

I think the cleanup that Dscho suggested elsewhere in the thread is a
good idea on top, but that can also just wait and come separately.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]