Re: [PATCH 1/4] push options: {pre,post}-receive hook learns about push options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 1, 2016 at 12:25 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
>> Compare to:
>>
>>   if test "$GIT_PUSH_VAR_force" = true
>>      ...
>
> OK.  As this is a new feature, I guess it is not too bad if we tell
> users that they cannot have duplicate keys in their <key,val> data
> they ask Git to transport.  They can do the key1=val1 key2=val2
> numbering themselves if that is really needed.
>

The original use case for us was to send out email on your behalf, so
git push -o CC=user1@domain -o CC=user2@domain would not work well with
this backend approach as the client would already yell at us for duplicate
keys.

Instead that has to be `git push -o CC=user1@domain,user2@domain
and we do need to parse the email addresses apart ourselves.

So currently I'd favor the _COUNT thing and we deliver a reasonable
_COUNT -> key/value parser/translator in the example hook.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]