On Thu, Jun 30, 2016 at 3:06 PM, Johannes Schindelin
<Johannes.Schindelin@xxxxxx> wrote:
> Even when NO_MMAP is empty, there might be no Unix sockets available (such
> as is the case on Windows). In any case, you really only want to skip
> these tests when index-helper is not available, so would you mind
> squashing this patch in?
>
> -- snipsnap --
> From: Johannes Schindelin <johannes.schindelin@xxxxxx>
> Subject: [PATCH] fixup! index-helper: new daemon for caching index and related
> stuff
>
> ---
> t/t7900-index-helper.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh
> index 6c9b4dd..12b5bf7 100755
> --- a/t/t7900-index-helper.sh
> +++ b/t/t7900-index-helper.sh
> @@ -10,8 +10,10 @@ Testing git index-helper
>
> . ./test-lib.sh
>
> -test -n "$NO_MMAP" && {
> - skip_all='skipping index-helper tests: no mmap'
> +git index-helper -h 2>/dev/null
> +test $? = 129 ||
So when NO_MMAP is set, "git index-helper -h" will set $? to 1. And we
correctly skip the tests as well. It's a bit subtle though. How about
"git help -a|grep index-helper"?
> +{
> + skip_all='skipping index-helper tests: no index-helper executable'
> test_done
> }
>
> --
> 2.9.0.270.g810e421
>
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html