On Thu, Jun 30, 2016 at 05:06:14AM -0400, Jeff King wrote: > The one thing that isn't fixed is the use of "141" to test for sigpipe > death. That should use test_match_signal, but that topic just got > re-rolled, too. And here's what the patch for that looks like (which can be applied if this topic and jk/test-match-signal are merged). -- >8 -- Subject: t5000: use test_match_signal We are testing for sigpipe death from git, and doing so portably requires using our test helper. Signed-off-by: Jeff King <peff@xxxxxxxx> --- Of course this does not help Windows at all, because we removed the "3" check from jk/test-match-signal. So this new test will probably need to be dealt with by Windows folks, one way or another (either extending test_match_signal, or just skipping the exit code check under the MINGW prereq). t/t5000-tar-tree.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh index 96d208d..6950d7d 100755 --- a/t/t5000-tar-tree.sh +++ b/t/t5000-tar-tree.sh @@ -365,8 +365,7 @@ test_expect_success 'generate tar with huge size' ' git archive HEAD echo $? >exit-code } | test_copy_bytes 4096 >huge.tar && - echo 141 >expect && - test_cmp expect exit-code + test_match_signal 13 "$(cat exit-code)" ' test_expect_success TAR_HUGE 'system tar can read our huge size' ' -- 2.9.0.317.g65b4e7c -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html