Hi Eric,
On Wed, 29 Jun 2016, Eric Sunshine wrote:
> On Wed, Jun 29, 2016 at 7:36 AM, Johannes Schindelin
> <johannes.schindelin@xxxxxx> wrote:
> > The vast majority of error messages in Git's source code which report a
> > bug use the convention to prefix the message with "BUG:".
> > [...]
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> > ---
> > diff --git a/merge-recursive.c b/merge-recursive.c
> > @@ -1853,7 +1852,7 @@ int merge_trees(struct merge_options *o,
> > - die(_("Unprocessed path??? %s"),
> > + die(_("BUG: unprocessed path??? %s"),
>
> This and others downcase the first word (which is consistent with
> modern practice)...
>
> > diff --git a/sha1_file.c b/sha1_file.c
> > @@ -795,7 +795,7 @@ void close_all_packs(void)
> > - die("BUG! Want to close pack marked 'do-not-close'");
> > + die("BUG: Want to close pack marked 'do-not-close'");
>
> ...but this one neglects to.
Thanks! Will be fixed as part of v2.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html