Re: [PATCH/RFC 3/3] diff.c: add --relative-names to be used with --name-only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 27, 2016 at 9:35 PM, Jeff King <peff@xxxxxxxx> wrote:
> On Mon, Jun 27, 2016 at 09:33:18PM +0200, Duy Nguyen wrote:
>
>> On Mon, Jun 27, 2016 at 9:24 PM, Jeff King <peff@xxxxxxxx> wrote:
>> > On Sun, Jun 26, 2016 at 07:16:16PM +0200, Nguyễn Thái Ngọc Duy wrote:
>> >
>> >> The difference with --relative option is, this option does not filter
>> >> paths outside cwd. You can add two more chars " ." on your command
>> >> line for that.
>> >
>> > Another difference seems to be that it applies only to --name-only, and
>> > not to other forms. I can see how "-p --relative-names" might be weird,
>> > because you'll get:
>> >
>> >   diff --git a/../foo/bar b/../foo/bar
>> >
>> > or something. But surely things like --name-status would want to support
>> > it?
>>
>> That's my plan :) Anything that does not start with a/ or b/ should
>> respect this new option.
>
> I guess it seems a bit unfortunate that:
>
>   git log -p --relative-names .
>
> would not be equivalent to:
>
>   git log -p --relative
>
> I am not entirely convinced that "a/../Documentation/git.txt" is that
> unreasonable. Sure, it looks weird, and probably nobody will be able to
> apply the patch. But it is what the user asked for.

If we go that far I would drop a/ and b/ because this is already
un-patchable, and without the prefix, the user can  happily copy and
paste again. Gaah lots more work..
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]