On Sat, Jun 25, 2016 at 9:21 PM, David Turner <novalis@xxxxxxxxxxx> wrote: > On 06/25/2016 10:33 AM, Duy Nguyen wrote: >>> >>> + /* >>> + * Our connection to the client is blocking since a >>> client >>> + * can always be killed by SIGINT or similar. >>> + */ >>> + set_socket_blocking_flag(client_fd, 0); >> >> >> Out of curiosity, do we really need this? I thought default behavior >> was always blocking (and checked linux kernel, it seemed to agree with >> me). Maybe for extra safety because other OSes may default to >> something else? > > > Yes -- see this bug report for details: > https://bugs.python.org/issue7995 > I think we should refer to this issue in the comment block right before set_socket_blocking_flag() call. Imagine a year from now, I may read the code, decide this code is useless and try to remove it. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html