Jeff King <peff@xxxxxxxx> writes: >> > +# When parsing, we'll pull out only the year from the date; that >> > +# avoids any question of timezones impacting the result. >> >> ... as long as the month-day part is not close to the year boundary. >> So this explanation is insuffucient to convince the reader that >> "that avoids any question" is correct, without saying that it is in >> August of year 4147. > > I thought that part didn't need to be said, but I can say it > (technically we can include the month, too, but I don't think that level > of accuracy is really important for these tests). Oh, I wasn't suggesting to include the month in the comparison. But to understand why it is safe from TZ jitters to test only year, the reader needs to know (or do the math herself) that the timestamp is away from the year boundary, so mentioning August in the justifying comment is needed. >> Seeing an awk piped into cut always makes me want to suggest a >> single sed/awk/perl invocation. > > I want the auto-splitting of awk, but then to auto-split the result > using a different delimiter. Is there a not-painful way to do that in > awk? > > I could certainly come up with a regex to do it in sed, but I wanted to > keep the parsing as liberal and generic as possible. > > Certainly I could do it in perl, but I had the general impression that > we prefer to keep the dependency on perl to a minimum. Maybe it doesn't > matter. Heh. It was merely "makes me want to suggest", not "I suggest". If I were doing this myself, I would have done a single sed but it does not matter. > I think we would want something more like: > > test_signal_match 13 $(cat exit-code) I like that. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html