On Thu, Jun 23, 2016 at 11:34:00AM -0700, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
> > We already support bold, underline, and similar attributes.
> > Let's add italic to the mix. According to the Wikipedia
> > page on ANSI colors, this attribute is "not widely
> > supported", but it does seem to work on my xterm.
> > ...
> > @@ -133,6 +133,7 @@ static int parse_attr(const char *name, size_t len)
> > #define ATTR(x, val, neg) { (x), strlen(x), (val), (neg) }
>
> I see this one was from an earlier reroll that did not use sizeof(x)-1;
> easy to fixup, though ;-)
Heh, whoops, yeah.
Gcc was actually happy with the `strlen` there, but I suspect that other
compilers might not be.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html