>
> +static int diff_populate_gitlink(struct diff_filespec *s, int size_only)
> +{
> + int len;
> + char *data = xmalloc(100);
> + len = snprintf(data, 100,
> + "Subproject commit %s\n", sha1_to_hex(s->sha1));
In userland I would use a local variable for an array of the size of 100.
I would normally only allocate when we are say 5x bigger.
I wonder if there is a specific reason why you decided upon xmalloc here?
I see no problem in using xmalloc but wonder if there is something I
should start to do differently??
Sam
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html