Hi Junio, On Tue, 21 Jun 2016, Junio C Hamano wrote: > Johannes Schindelin <johannes.schindelin@xxxxxx> writes: > > > Note: there are more places in the builtin am code that ignore > > errors returned from library functions. Fixing those is outside the > > purview of the current patch series, though. > > The caller of parse_mail() and parse_mail_rebase() is not prepared > to see an error code in the returned value from these function, > which are to return a boolean telling the caller to skip or use the > patch file. At least the caller needs to notice negative return and > made to die/exit(128), instead of silently skipping a corrupt or > unopenable patch, no? Otherwise this will change the behaviour. Yeah, that is another rabbit hole I really do not want to dive in. Will leave it alone, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html