Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> That is a very convincing argument. So convincing that I wanted to change
> the patch to guard behind `diff_use_color_default == GIT_COLOR_AUTO`.
I actually was expecting, instead of your:
if (output_directory) {
+ rev.diffopt.use_color = 0;
if (use_stdout)
die(_("standard output, or directory, which one?"));
an update would say
if (output_directory) {
if (rev.diffopt.use_color == GIT_COLOR_AUTO)
rev.diffopt.use_color = 0;
if (use_stdout)
die(_("standard output, or directory, which one?"));
I didn't expect you to check diff_use_color_default exactly for the
reason why you say "But that is the wrong variable".
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html