Jeff King <peff@xxxxxxxx> writes: > I am on the fence regarding oidcpy/oidclr. I agree they _could_ be > struct assignments, but it is also convenient to have concept wrapped up > in a function, in case we ever want to do anything more complicated. Also dedicated functions have documenation value. There are some things that currently use the same 40-hex that is the result of running SHA-1 but are not object names (e.g. patch id, and rerere id). They use the same hashcpy()/hashcmp() helpers as object names do, but the code that use them probably do not want to be converted to struct oid and oidcpy(). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html