On Sat, Jun 18, 2016 at 9:49 PM, David Turner <novalis@xxxxxxxxxxx> wrote:
> On Sat, 2016-06-18 at 20:57 -0400, Emily Xie wrote:
>> + while (argv[n]) {
>> + if (*argv[n] == '\0') {
>> + die("Empty string is not a valid pathspec.");
>> + }
>
> nit: git style doesn't use {} on one-statement ifs.
Also, drop the full-stop (period) from the error message and, to be
consistent with modern practice, don't capitalize the first word.
Finally, the string should be localizable, so wrap it in _(...):
die(_("empty string not valid pathspec"));
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html