This is the reroll of branch mh/ref-iterators promised and discussed
earlier [1]. There are no showstoppers here, but it would be
preferable to merge this version rather than v2.
This version squashes in Ramsay's patch [2], addresses Eric's
comments, and incorporates the whitespace fix that you made when
incorporating v2.
List of changes relative to v2:
* In "refs: introduce an iterator interface":
* Make two vtables private.
* Add a whitespace fix from Junio's mh/ref-iterators.
* In "dir_iterator: new API for iterating over a directory tree":
* Add and improve some comments and docstrings.
* Fix some formatting problems.
* Use a for rather than a while loop in `dir_iterator_abort()` to
improve the clarity.
* Warn on failures of `opendir()`, `readdir()`, and `closedir()`
that can't be explained as a simple race.
* In "for_each_reflog(): reimplement using iterators", make the vtable
private.
These changes are also available from my GitHub fork [3] as branch
"ref-iterators".
Michael
[1] http://article.gmane.org/gmane.comp.version-control.git/296883
[2] http://thread.gmane.org/gmane.comp.version-control.git/296801
[3] https://github.com/mhagger/git
Michael Haggerty (13):
refs: remove unnecessary "extern" keywords
do_for_each_ref(): move docstring to the header file
refs: use name "prefix" consistently
delete_refs(): add a flags argument
remote rm: handle symbolic refs correctly
get_ref_cache(): only create an instance if there is a submodule
entry_resolves_to_object(): rename function from
ref_resolves_to_object()
ref_resolves_to_object(): new function
refs: introduce an iterator interface
do_for_each_ref(): reimplement using reference iteration
for_each_reflog(): don't abort for bad references
dir_iterator: new API for iterating over a directory tree
for_each_reflog(): reimplement using iterators
Makefile | 2 +
builtin/fetch.c | 2 +-
builtin/remote.c | 8 +-
dir-iterator.c | 202 +++++++++++++++++
dir-iterator.h | 87 +++++++
iterator.h | 81 +++++++
refs.c | 20 ++
refs.h | 139 +++++++-----
refs/files-backend.c | 629 +++++++++++++++++++++++++++++++--------------------
refs/iterator.c | 384 +++++++++++++++++++++++++++++++
refs/refs-internal.h | 226 +++++++++++++++++-
11 files changed, 1458 insertions(+), 322 deletions(-)
create mode 100644 dir-iterator.c
create mode 100644 dir-iterator.h
create mode 100644 iterator.h
create mode 100644 refs/iterator.c
--
2.8.1
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html