Seth Falcon <sethfalcon@xxxxxxxxx> wrote: > A few weeks ago I reported a symlink related error with git-svn and > I've now had a chance to track down a few more details. The trigger > seems to be if a file is removed from svn and then later added as a > symlink. The error I get is: > > error: git-checkout-index: unable to create symlink foo.txt (Invalid argument) > > This is from the call to symlink(new, path) in entry.c and it seems > that new is ''. I can't reproduce it on Linux with ext3. I translated your recipe into a test script in the patch below. Anybody familiar with OSX and/or HFS know if there's a workaround or fix for this? From: Eric Wong <normalperson@xxxxxxxx> Date: Sat, 14 Apr 2007 13:03:24 -0700 Subject: [PATCH] git-svn: add test to handle conversion from file to symlink This does not trigger any failures on my Linux machine with ext3, but it may fail on OSX and/or HFS. This test is based on a bug report by Seth Falcon: http://permalink.gmane.org/gmane.comp.version-control.git/44445 Signed-off-by: Eric Wong <normalperson@xxxxxxxx> --- t/t9112-git-svn-file-to-symlink.sh | 36 ++++++++++++++++++++++++++++++++++++ 1 files changed, 36 insertions(+), 0 deletions(-) create mode 100755 t/t9112-git-svn-file-to-symlink.sh diff --git a/t/t9112-git-svn-file-to-symlink.sh b/t/t9112-git-svn-file-to-symlink.sh new file mode 100755 index 0000000..f94310f --- /dev/null +++ b/t/t9112-git-svn-file-to-symlink.sh @@ -0,0 +1,36 @@ +#!/bin/sh +# Copyright (c) 2007 Eric Wong +test_description='git-svn file to symlink' +. ./lib-git-svn.sh + +test_expect_success 'create file in svn repository' " + svn co '$svnrepo' svn && + cd svn && + echo 123 > foo.txt && + svn add foo.txt && + svn commit -m 'add a file' + cd .. + " + +test_expect_success 'clone with git-svn' "pwd && git svn clone '$svnrepo' git" + +test_expect_success 'remove and add file as symlink in svn' " + cd svn && + echo 123 > bar.txt && + svn add bar.txt && + svn commit -m 'add bar' && + svn rm foo.txt && + svn commit -m 'remove foo' && + ln -s bar.txt foo.txt && + svn add foo.txt && + svn ci -m 'add foo as symlink' + cd .. + " + +test_expect_success 'rebase in git-svn' " + cd git && + git svn rebase + cd .. + " + +test_done -- Eric Wong - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html