On Fri, May 20, 2016 at 4:45 AM, David Turner <dturner@xxxxxxxxxxxxxxxx> wrote:
> diff --git a/read-cache.c b/read-cache.c
> index 1719f5a..8ec4be3 100644
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -1235,7 +1235,7 @@ int refresh_index(struct index_state *istate, unsigned int flags,
> if (!new) {
> const char *fmt;
>
> - if (really && cache_errno == EINVAL) {
> + if (really || cache_errno == EINVAL) {
> /* If we are doing --really-refresh that
> * means the index is not valid anymore.
> */
This looks really odd. I don't see why we would need this. It seems
first appeared in your "do not apply" patch [1]. Maybe leftover?
I found this while re-reading the series and I have not put much time
in studying this code yet. So I may be wrong. I'll post again if I
find that it's true after some more staring.
[1] http://article.gmane.org/gmane.comp.version-control.git/288567
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html