Jeff King <peff@xxxxxxxx> writes: > Interesting. But `git show` on the commit in question (f216419e5) does > not have any problems. It looks like bisect's internal "show the commit" > code does not properly call setup_revisions() to finalize the "struct > rev_info". That leaves the expand_tabs_in_log flag as "-1", which then > ends up cast to an unsigned of 2^64 when we use it in a size > computation. Yuck > And who knows what other bugs have been lurking there over the years; > there are other flags that should be finalized by setup_revision(), too. > > This patch should fix it. Looks sensible. > diff --git a/bisect.c b/bisect.c > index 6d93edb..dc13319 100644 > --- a/bisect.c > +++ b/bisect.c > @@ -890,6 +890,7 @@ static void show_diff_tree(const char *prefix, struct commit *commit) > if (!opt.diffopt.output_format) > opt.diffopt.output_format = DIFF_FORMAT_RAW; > > + setup_revisions(0, NULL, &opt, NULL); > log_tree_commit(&opt, commit); > } > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html