On Tue, Jun 14, 2016 at 12:10 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > >> I agree with Junio that moving the sigchain_pop() into the error >> handling code-path, if possible, would be a nice improvement. > > Yeah, "if possible" is really what I was not sure about---is it safe > to do the _push() thing before start_command(), which presumably > would affect both the main and the forked processes? Good point. But we do exec() very shortly in the forked process, which should reset signal table back to default. So probably not a bad thing. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html